mypy: Module has no attribute "connect" [attr-defined]

Yes, that would be the most straight forward approach, if it weren’t for backwards-compatibility.

I always documented the import paths as websockets.connect and websockets.serve rather than websockets.client.connect and websockets.server.serve. I did to keep things simple: just import anything you need from websockets.

This strategy has unfortunate consequences but I feel it’s best to live with the consequences.

I’d be open to that, with a test that checks that assertEquals(set(websockets.__all__), set(<current definition>)). There’s no obvious place to put that test; try something; it won’t be hard to change later anyway.

Ideally, I’d like to perform imports on demand, so programs that only use the client side don’t load the server side needlessly and vice-versa. This will likely open a whole can of worns so it shouldn’t prevent a quick improvement here.